DPL Analysis: Event mixing: Refactor binning policy to accept lambdas#9291
Closed
saganatt wants to merge 6 commits into
Closed
DPL Analysis: Event mixing: Refactor binning policy to accept lambdas#9291saganatt wants to merge 6 commits into
saganatt wants to merge 6 commits into
Conversation
Collaborator
Author
|
Split into other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ciao @ktf @aalkin, @jgrosseo
this allows using custom lambda functions for binning and mixing. Let me know if you have any coding suggestions.
ColumnBinningPolicy preserves the old interface for using columns only. However, these changes might still break O2Physics. I can work around this by a series of interleaved O2 and O2Physics PRs, but maybe let's first agree on the O2 implementation. And I will then split this PR.